Site Editor: Organise semantic template parts #29030
Merged
+133
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
added
the
[Feature] Site Editor
david-szabo97
requested review from
mattwiebe,
jameskoster,
vindl,
Copons,
jeyip and
Addison-Stavlo
|
Size Change: +292 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
david-szabo97
requested review from
ajitbohra,
nerrad and
ntwb
as code owners
aristath
approved these changes
Feb 16, 2021
vindl
reviewed
Feb 16, 2021
There was a problem hiding this comment.
Considering that most of the sites will likely have just one template part per area, one downside of organizing things this way is that it introduces one more click to get to the menu with only one item. On the other hand, it better communicates what template parts are and their relationship with templates so it might be worthwhile to try this out.
| title: __( 'Sidebars' ), | ||
| }, | ||
| { | ||
| area: null, |
There was a problem hiding this comment.
Would it make sense to aligning this with corresponding value in @Addison-Stavlo's PR #28410, that is to use uncategorized here too?
There was a problem hiding this comment.
null includes all template parts from the areas that aren't specified in this constant array. In this case template parts with header, footer or sidebar will be excluded from General but everything else will be included. This only matters if a theme has an area besides the header,footer and sidebar. So basically null is a catch-all, excluding items from the three other areas.
There was a problem hiding this comment.
What I was trying to say is that is that we are using uncategorized for the same thing (catch-all) on back end.
There was a problem hiding this comment.
Just checked the code you are right. I thought we allow other areas as well. I'll update the code to use uncategorized
vindl
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #27877
How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: